sk0x50 commented on code in PR #3373:
URL: https://github.com/apache/ignite-3/pull/3373#discussion_r1521556200
##########
modules/core/src/main/java/org/apache/ignite/internal/util/ExceptionUtils.java:
##########
@@ -951,7 +951,7 @@ <T extends Throwable> T copy(MethodHandle constructor, UUID
traceId, int code, S
* </code></pre>
*
*/
- private static class UtilException extends Throwable {
+ private static class UtilException extends RuntimeException {
Review Comment:
> Currently this exception is not the one you would usually catch but it
seems it's designed exactly to be caught.
This exception was introduced due to internal technical needs. It is not
assumed that it can be thrown directly.
However, in this particular case, the exact type does not matter, we can use
`RuntimeException`.
##########
modules/core/src/main/java/org/apache/ignite/internal/util/ExceptionUtils.java:
##########
@@ -951,7 +951,7 @@ <T extends Throwable> T copy(MethodHandle constructor, UUID
traceId, int code, S
* </code></pre>
*
*/
- private static class UtilException extends Throwable {
+ private static class UtilException extends RuntimeException {
Review Comment:
> Currently this exception is not the one you would usually catch but it
seems it's designed exactly to be caught.
This exception was introduced due to internal technical needs. It is not
assumed that it can be thrown directly.
However, in this particular case, the exact type does not matter, we can use
`RuntimeException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
