tkalkirill commented on code in PR #3406: URL: https://github.com/apache/ignite-3/pull/3406#discussion_r1522831165
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/IndexStorageFactory.java: ########## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory.mv; + +import java.util.concurrent.atomic.AtomicLong; +import org.apache.ignite.internal.lang.IgniteInternalCheckedException; +import org.apache.ignite.internal.pagememory.PageIdAllocator; +import org.apache.ignite.internal.pagememory.PageMemory; +import org.apache.ignite.internal.pagememory.reuse.ReuseList; +import org.apache.ignite.internal.pagememory.util.PageLockListenerNoOp; +import org.apache.ignite.internal.storage.RowId; +import org.apache.ignite.internal.storage.StorageException; +import org.apache.ignite.internal.storage.index.StorageHashIndexDescriptor; +import org.apache.ignite.internal.storage.index.StorageIndexDescriptor; +import org.apache.ignite.internal.storage.index.StorageSortedIndexDescriptor; +import org.apache.ignite.internal.storage.pagememory.AbstractPageMemoryTableStorage; +import org.apache.ignite.internal.storage.pagememory.index.freelist.IndexColumnsFreeList; +import org.apache.ignite.internal.storage.pagememory.index.hash.HashIndexTree; +import org.apache.ignite.internal.storage.pagememory.index.hash.PageMemoryHashIndexStorage; +import org.apache.ignite.internal.storage.pagememory.index.meta.IndexMeta; +import org.apache.ignite.internal.storage.pagememory.index.meta.IndexMetaTree; +import org.apache.ignite.internal.storage.pagememory.index.sorted.PageMemorySortedIndexStorage; +import org.apache.ignite.internal.storage.pagememory.index.sorted.SortedIndexTree; + +/** + * Class responsible for creating Index B-Trees. + */ +class IndexStorageFactory { + private final AbstractPageMemoryTableStorage tableStorage; + + private final int partitionId; + + private final IndexMetaTree indexMetaTree; + + private final IndexColumnsFreeList indexFreeList; + + private final ReuseList indexReuseList; + + @FunctionalInterface + private interface IndexTreeConstructor<T> { + T createTree(long metaPageId) throws IgniteInternalCheckedException; + } + + private static class IndexTreeAndMeta<T> { + final T indexTree; + + final IndexMeta indexMeta; + + IndexTreeAndMeta(T indexTree, IndexMeta indexMeta) { + this.indexTree = indexTree; + this.indexMeta = indexMeta; + } + } + + IndexStorageFactory( + AbstractPageMemoryTableStorage tableStorage, + int partitionId, + IndexMetaTree indexMetaTree, + IndexColumnsFreeList indexFreeList, + ReuseList indexReuseList + ) { + this.tableStorage = tableStorage; + this.partitionId = partitionId; + this.indexMetaTree = indexMetaTree; + this.indexFreeList = indexFreeList; + this.indexReuseList = indexReuseList; + } + + /** + * Creates a new Page Memory-based Hash Index storage. + */ + PageMemoryHashIndexStorage createHashIndexStorage(StorageHashIndexDescriptor indexDescriptor) { + IndexTreeAndMeta<HashIndexTree> treeAndMeta = createHashIndexTreeAndMeta(indexDescriptor); + + return new PageMemoryHashIndexStorage( + treeAndMeta.indexMeta, + indexDescriptor, + indexFreeList, + treeAndMeta.indexTree, + indexMetaTree, + tableStorage.isVolatile() + ); + } + + /** + * Restores an existing Page Memory-based Hash Index storage. + */ + PageMemoryHashIndexStorage restoreHashIndexStorage(StorageHashIndexDescriptor indexDescriptor, IndexMeta indexMeta) { + return new PageMemoryHashIndexStorage( + indexMeta, + indexDescriptor, + indexFreeList, + restoreHashIndexTree(indexMeta), + indexMetaTree, + tableStorage.isVolatile() + ); + } + + private IndexTreeAndMeta<HashIndexTree> createHashIndexTreeAndMeta(StorageHashIndexDescriptor indexDescriptor) { + return createIndexTree( + indexDescriptor, + metaPageId -> HashIndexTree.createNew( + tableStorage.getTableId(), + Integer.toString(tableStorage.getTableId()), + partitionId, + tableStorage.dataRegion().pageMemory(), + PageLockListenerNoOp.INSTANCE, + new AtomicLong(), + metaPageId, + indexReuseList, + indexDescriptor + )); + } + + private HashIndexTree restoreHashIndexTree(IndexMeta indexMeta) { + try { + return HashIndexTree.restoreExisting( + tableStorage.getTableId(), + Integer.toString(tableStorage.getTableId()), + partitionId, + tableStorage.dataRegion().pageMemory(), + PageLockListenerNoOp.INSTANCE, + new AtomicLong(), + indexMeta.metaPageId(), + indexReuseList + ); + } catch (IgniteInternalCheckedException e) { + throw new StorageException(e); + } + } + + /** + * Creates a new Page Memory-based Sorted Index storage. + */ + PageMemorySortedIndexStorage createSortedIndexStorage(StorageSortedIndexDescriptor indexDescriptor) { + IndexTreeAndMeta<SortedIndexTree> treeAndMeta = createSortedIndexTreeAndMeta(indexDescriptor); + + return new PageMemorySortedIndexStorage( + treeAndMeta.indexMeta, + indexDescriptor, + indexFreeList, + treeAndMeta.indexTree, + indexMetaTree, + tableStorage.isVolatile() + ); + } + + /** + * Restores an existing Page Memory-based Sorted Index storage. + */ + PageMemorySortedIndexStorage restoreSortedIndexStorage(StorageSortedIndexDescriptor indexDescriptor, IndexMeta indexMeta) { + return new PageMemorySortedIndexStorage( + indexMeta, + indexDescriptor, + indexFreeList, + restoreSortedIndexTree(indexDescriptor, indexMeta), + indexMetaTree, + tableStorage.isVolatile() + ); + } + + private IndexTreeAndMeta<SortedIndexTree> createSortedIndexTreeAndMeta(StorageSortedIndexDescriptor indexDescriptor) { + return createIndexTree( + indexDescriptor, + metaPageId -> SortedIndexTree.createNew( + tableStorage.getTableId(), + Integer.toString(tableStorage.getTableId()), + partitionId, + tableStorage.dataRegion().pageMemory(), + PageLockListenerNoOp.INSTANCE, + new AtomicLong(), + metaPageId, + indexReuseList, + indexDescriptor + ) + ); + } + + private SortedIndexTree restoreSortedIndexTree(StorageSortedIndexDescriptor indexDescriptor, IndexMeta indexMeta) { + try { + return SortedIndexTree.restoreExisting( + tableStorage.getTableId(), + Integer.toString(tableStorage.getTableId()), + partitionId, + tableStorage.dataRegion().pageMemory(), + PageLockListenerNoOp.INSTANCE, + new AtomicLong(), + indexMeta.metaPageId(), + indexReuseList, + indexDescriptor + ); + } catch (IgniteInternalCheckedException e) { + throw new StorageException(e); + } + } + + /** + * Creates a new B-Tree for the given {@code indexStorage}. + */ + void updateDataStructuresIn(PageMemoryHashIndexStorage indexStorage) { + HashIndexTree indexTree = createHashIndexTreeAndMeta(indexStorage.indexDescriptor()).indexTree; + + indexStorage.updateDataStructures(indexFreeList, indexTree); + } + + /** + * Creates a new B-Tree for the given {@code indexStorage}. + */ + void updateDataStructuresIn(PageMemorySortedIndexStorage indexStorage) { + SortedIndexTree indexTree = createSortedIndexTreeAndMeta(indexStorage.indexDescriptor()).indexTree; + + indexStorage.updateDataStructures(indexFreeList, indexTree); + } + + private <T> IndexTreeAndMeta<T> createIndexTree(StorageIndexDescriptor descriptor, IndexTreeConstructor<T> treeConstructor) { + try { + PageMemory pageMemory = tableStorage.dataRegion().pageMemory(); + + long metaPageId = pageMemory.allocatePage(tableStorage.getTableId(), partitionId, PageIdAllocator.FLAG_AUX); + + T tree = treeConstructor.createTree(metaPageId); + + var indexMeta = new IndexMeta(descriptor.id(), metaPageId, RowId.lowestRowId(partitionId).uuid()); + + boolean replaced = indexMetaTree.putx(indexMeta); + + assert !replaced; Review Comment: ```suggestion assert !replaced : descriptor.id(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
