sanpwc commented on code in PR #3404:
URL: https://github.com/apache/ignite-3/pull/3404#discussion_r1523303998
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java:
##########
@@ -153,6 +151,8 @@ public void testSafeTimeReorderingOnLeaderReElection()
throws Exception {
RaftGroupService anotherClient = aliveNode.get().raftClient;
+ assertThat(anotherClient.refreshLeader(), willCompleteSuccessfully());
Review Comment:
Because otherwise leader might not be elected -> maxObservableTimestamp ==
Long.MaxValue -> command will fail with SafeTimeReorderingException. In case of
common logic that will trigger a retry which is expected, however within given
particular test we do not test the retry, thus we should carefully prepare the
preconditions, meaning leader election.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
