PakhomovAlexander commented on code in PR #3374:
URL: https://github.com/apache/ignite-3/pull/3374#discussion_r1523422093
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateZoneImpl.java:
##########
@@ -75,6 +70,53 @@ CreateZoneImpl partitions(Integer n) {
return this;
}
+ CreateZoneImpl affinity(String affinity) {
+ Objects.requireNonNull(affinity, "Affinity function must not be null");
+
+ withOptions.add(WithOption.affinity(affinity));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjust(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
+
+ withOptions.add(WithOption.dataNodesAutoAdjust(adjust));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjustScaleUp(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
Review Comment:
same
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateZoneImpl.java:
##########
@@ -75,6 +70,53 @@ CreateZoneImpl partitions(Integer n) {
return this;
}
+ CreateZoneImpl affinity(String affinity) {
+ Objects.requireNonNull(affinity, "Affinity function must not be null");
+
+ withOptions.add(WithOption.affinity(affinity));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjust(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
Review Comment:
What timeout must not be null?
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateZoneImpl.java:
##########
@@ -75,6 +70,53 @@ CreateZoneImpl partitions(Integer n) {
return this;
}
+ CreateZoneImpl affinity(String affinity) {
+ Objects.requireNonNull(affinity, "Affinity function must not be null");
+
+ withOptions.add(WithOption.affinity(affinity));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjust(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
+
+ withOptions.add(WithOption.dataNodesAutoAdjust(adjust));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjustScaleUp(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
+
+ withOptions.add(WithOption.dataNodesAutoAdjustScaleUp(adjust));
+ return this;
+ }
+
+ CreateZoneImpl dataNodesAutoAdjustScaleDown(Integer adjust) {
+ Objects.requireNonNull(adjust, "Timeout must not be null");
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
