rpuch commented on code in PR #3409:
URL: https://github.com/apache/ignite-3/pull/3409#discussion_r1524320430
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/ScanVersionsCursor.java:
##########
@@ -63,34 +63,42 @@ public void close() {
@Override
public boolean hasNext() {
- if (hasNext != null) {
- return hasNext;
- }
+ return storage.busy(() -> {
Review Comment:
I think we must first guarantee correctness and safety and only then
optimize. Here, I just added a missing guard, `busy()` is still taken by other
cursors.
If there is actually a problem with the current approach, we should probably
change it for all cursors, it's a subject for another task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
