denis-chudov commented on code in PR #3401:
URL: https://github.com/apache/ignite-3/pull/3401#discussion_r1524783762
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -368,15 +369,14 @@ private void updateLeaseBatchInternal() {
writeNewLease(grpId, lease, candidate, renewedLeases,
toBeNegotiated);
continue;
+ } else {
+ agreement.checkValid(grpId,
topologyTracker.currentTopologySnapshot(), assignments);
Review Comment:
we don't need to check the validity if the agreement is ready (accepted also
means ready), that's why I put it to `else` block
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -368,15 +369,14 @@ private void updateLeaseBatchInternal() {
writeNewLease(grpId, lease, candidate, renewedLeases,
toBeNegotiated);
continue;
+ } else {
+ agreement.checkValid(grpId,
topologyTracker.currentTopologySnapshot(), assignments);
Review Comment:
we don't need to check the validity if the agreement is `ready` (`accepted`
also means `ready`), that's why I put it to `else` block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
