rpuch commented on code in PR #3438:
URL: https://github.com/apache/ignite-3/pull/3438#discussion_r1530392499


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/meta/IndexMetaKey.java:
##########
@@ -38,4 +38,23 @@ public IndexMetaKey(int indexId) {
     public int indexId() {
         return indexId;
     }
+
+    @Override
+    public boolean equals(Object o) {

Review Comment:
   Is this just to make a test a bit more tidy? I'm not sure we should add it 
here. In the test an `ArgumentCaptor` can be used to verify that the correct 
key is used for destruction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to