tkalkirill commented on code in PR #3446:
URL: https://github.com/apache/ignite-3/pull/3446#discussion_r1533681925
##########
modules/table/src/testFixtures/java/org/apache/ignite/internal/table/TableTestUtils.java:
##########
@@ -329,4 +340,41 @@ public static void startBuildingIndex(CatalogManager
catalogManager, int indexId
public static void makeIndexAvailable(CatalogManager catalogManager, int
indexId) {
assertThat(catalogManager.execute(MakeIndexAvailableCommand.builder().indexId(indexId).build()),
willCompleteSuccessfully());
}
+
+ /**
+ * Adds a column to the table to catalog.
+ *
+ * @param catalogManager Catalog manager.
+ * @param schemaName Schema name.
+ * @param tableName Table name.
+ * @param columnName Column name.
+ * @param columnType Column type.
+ */
+ public static void addColumnForTable(
Review Comment:
fix it
##########
modules/table/src/testFixtures/java/org/apache/ignite/internal/table/TableTestUtils.java:
##########
@@ -329,4 +340,41 @@ public static void startBuildingIndex(CatalogManager
catalogManager, int indexId
public static void makeIndexAvailable(CatalogManager catalogManager, int
indexId) {
assertThat(catalogManager.execute(MakeIndexAvailableCommand.builder().indexId(indexId).build()),
willCompleteSuccessfully());
}
+
+ /**
+ * Adds a column to the table to catalog.
+ *
+ * @param catalogManager Catalog manager.
+ * @param schemaName Schema name.
+ * @param tableName Table name.
+ * @param columnName Column name.
+ * @param columnType Column type.
+ */
+ public static void addColumnForTable(
+ CatalogManager catalogManager,
+ String schemaName,
+ String tableName,
+ String columnName,
+ ColumnType columnType
+ ) {
+ CatalogCommand command = AlterTableAddColumnCommand.builder()
+ .schemaName(schemaName)
+ .tableName(tableName)
+
.columns(List.of(ColumnParams.builder().name(columnName).type(columnType).build()))
+ .build();
+
+ assertThat(catalogManager.execute(command),
willCompleteSuccessfully());
+ }
+
+ /**
+ * Adds a column to the table from {@link
#createSimpleTable(CatalogManager, String)} to catalog.
+ *
+ * @param catalogManager Catalog manager.
+ * @param tableName Table name.
+ * @param columnName Column name.
+ * @param columnType Column type.
+ */
+ public static void addColumnForSimpleTable(CatalogManager catalogManager,
String tableName, String columnName, ColumnType columnType) {
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
