ygerzhedovich commented on code in PR #3447:
URL: https://github.com/apache/ignite-3/pull/3447#discussion_r1539064657
##########
modules/core/src/main/java/org/apache/ignite/internal/util/subscription/OrderedMergePublisher.java:
##########
@@ -208,8 +208,7 @@ private void updateError(Throwable throwable) {
if (current == null) {
next = throwable;
} else {
- next = new Throwable();
- next.addSuppressed(current);
+ next = current;
Review Comment:
this will not work properly. Below you have CAS which check that currest
still the same and set next as a new value. But you always use the same value
for next and current ones - so, the CAS from second error will be always done
even it have had concurrent modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
