sashapolo commented on code in PR #3491: URL: https://github.com/apache/ignite-3/pull/3491#discussion_r1540685149
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/AntiHijackTable.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed; + +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.Executor; +import org.apache.ignite.internal.table.AntiHijackKeyValueView; +import org.apache.ignite.internal.table.AntiHijackRecordView; +import org.apache.ignite.internal.thread.PublicApiThreading; +import org.apache.ignite.internal.wrapper.Wrapper; +import org.apache.ignite.internal.wrapper.Wrappers; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.table.RecordView; +import org.apache.ignite.table.Table; +import org.apache.ignite.table.Tuple; +import org.apache.ignite.table.mapper.Mapper; + +/** + * Wrapper around {@link Table} that adds protection agains thread hijacking by users. + * + * @see PublicApiThreading#preventThreadHijack(CompletableFuture, Executor) + */ +class AntiHijackTable implements Table, Wrapper { + private final Table table; + private final Executor asyncContinuationExecutor; + + /** + * Constructor. + */ + AntiHijackTable(Table table, Executor asyncContinuationExecutor) { + this.table = table; + this.asyncContinuationExecutor = asyncContinuationExecutor; + } + + @Override + public String name() { + return table.name(); + } + + @Override + public <R> RecordView<R> recordView(Mapper<R> recMapper) { + return new AntiHijackRecordView<>(table.recordView(recMapper), asyncContinuationExecutor); + } + + @Override + public RecordView<Tuple> recordView() { + return new AntiHijackRecordView<>(table.recordView(), asyncContinuationExecutor); + } + + @Override + public <K, V> KeyValueView<K, V> keyValueView(Mapper<K> keyMapper, Mapper<V> valMapper) { + return new AntiHijackKeyValueView<>(table.keyValueView(keyMapper, valMapper), asyncContinuationExecutor); + } + + @Override + public KeyValueView<Tuple, Tuple> keyValueView() { + return new AntiHijackKeyValueView<>(table.keyValueView(), asyncContinuationExecutor); + } + + @Override + public <T> T unwrap(Class<T> classToUnwrap) { + return Wrappers.unwrap(table, classToUnwrap); Review Comment: Why not just return the `table`? We could simply add an assertion in the constructor, that the delegate is not a wrapper. This applies to all similar places as well ########## modules/core/src/main/java/org/apache/ignite/internal/wrapper/Wrappers.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.wrapper; + +/** + * Utils for unwrapping {@link Wrapper} instances. + */ +public class Wrappers { + /** + * Unwraps an object. Either invokes {@link Wrapper#unwrap(Class)} if it's a Wrapper, or tries to cast directly otherwise. + * + * @param object Object to unwrap. + * @param classToUnwrap Class which is to be unwrapped. + */ + public static <T> T unwrap(Object object, Class<T> classToUnwrap) { + if (object instanceof Wrapper) { Review Comment: 1. Do we really need to support "nested" wrappers? What's the point? 2. Can we make `Wrapper.unwrap` `default` and move this code there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
