sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579880267
########## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingManager.java: ########## @@ -142,20 +143,26 @@ public CompletableFuture<Void> start() { } @Override - public void stop() throws Exception { + public CompletableFuture<Void> stopAsync() { if (!stopGuard.compareAndSet(false, true)) { - return; + return nullCompletedFuture(); } busyLock.block(); - closeAllManually( - indexBuilder, - indexAvailabilityController, - indexBuildController, - changeIndexStatusTaskController - ); + try { + closeAllManually( + indexBuilder, + indexAvailabilityController, + indexBuildController, + changeIndexStatusTaskController + ); + } catch (Exception e) { + return failedFuture(e); + } shutdownAndAwaitTermination(executor, 10, TimeUnit.SECONDS); Review Comment: I'd also include shutdownAndAwaitTermination(executor, ...) into closeAllManually() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org