Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579915557
##########
modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java:
##########
@@ -178,24 +177,12 @@ public CompletableFuture<Void> start() {
)
).join();
- bootstrapFactory.start();
-
- clusterSvc.start();
-
- return nullCompletedFuture();
+ return allOf(bootstrapFactory.startAsync(),
clusterSvc.startAsync());
}
@Override
- public void stop() {
- try {
- IgniteUtils.closeAll(
- clusterSvc::stop,
- bootstrapFactory::stop,
- nodeConfigurationMgr::stop
- );
- } catch (Exception e) {
- throw new RuntimeException(e);
- }
+ public CompletableFuture<Void> stopAsync() {
+ return allOf(clusterSvc.stopAsync(),
bootstrapFactory.stopAsync(), nodeConfigurationMgr.stopAsync());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
