alievmirza commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580625464
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java:
##########
@@ -297,7 +301,8 @@ private PartialNode startPartialNode(int idx) {
);
for (IgniteComponent component : otherComponents) {
- component.start();
+ // TODO: had to start without waiting as the test otherwise fails
with timeout.
Review Comment:
The problems is that in the common node start you have to call
`metaStorageMgr.notifyRevisionUpdateListenerOnStart()`, so some components
(like DZM could proceed with its logic, because it waits for some
VersionedValues)
```
CompletableFuture<Void> startupConfigurationUpdate =
notifyConfigurationListeners();
CompletableFuture<Void> startupRevisionUpdate =
metaStorageMgr.notifyRevisionUpdateListenerOnStart();
return CompletableFuture.allOf(startupConfigurationUpdate,
startupRevisionUpdate, startFuture)
```
but in this partial node you wait for node to be started without calling
`notifyRevisionUpdateListenerOnStart`, so it can't start. At lease this is the
root cause for `ItIgniteDistributionZoneManagerNodeRestartTest`. I bet the
problem is the same for `ItIgniteNodeRestartTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
