JAkutenshi commented on code in PR #3757:
URL: https://github.com/apache/ignite-3/pull/3757#discussion_r1609330592
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java:
##########
@@ -105,9 +108,18 @@ public DefaultLogStorageFactory(String nodeName,
Supplier<Path> logPathSupplier)
);
}
- /** {@inheritDoc} */
@Override
- public void start() {
+ public CompletableFuture<Void> startAsync() {
+ // This is effectively a sync implementation.
+ try {
+ start();
+ return nullCompletedFuture();
+ } catch (RuntimeException ex) {
+ return failedFuture(ex);
+ }
+ }
+
Review Comment:
By meaning of startAsync -- start() looks like should be started in future:
`CompletableFuture.runAsync(() -> start());` The only question is: in most
cases a component's executor should be provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
