xtern commented on code in PR #3786:
URL: https://github.com/apache/ignite-3/pull/3786#discussion_r1609563889
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteMethod.java:
##########
@@ -98,17 +98,13 @@ public enum IgniteMethod {
IS_NOT_DISTINCT_FROM(Objects.class, "equals", Object.class, Object.class),
/** See {@link UUID#randomUUID()}. */
- RAND_UUID(UUID.class, "randomUUID"),
+ RAND_UUID(IgniteSqlFunctions.class, "randUuid"),
LENGTH(IgniteSqlFunctions.class, "length", Object.class),
OCTET_LENGTH(IgniteSqlFunctions.class, "octetLength", ByteString.class),
OCTET_LENGTH2(IgniteSqlFunctions.class, "octetLength", String.class),
- /** See {@link IgniteSqlFunctions#genRandomUuid()}. */
- // TODO This function should removed when
https://issues.apache.org/jira/browse/IGNITE-19103 is complete.
- GEN_RANDOM_UUID(IgniteSqlFunctions.class, "genRandomUuid"),
Review Comment:
please remove the function body from `IgniteSqlFunctions` class as well.
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/CatalogUtils.java:
##########
@@ -593,28 +593,28 @@ public static HybridTimestamp
clusterWideEnsuredActivationTsSafeForRoReads(
return defaultZone != null ? defaultZone.id() : null;
}
- /**
- * Return {@code true} if a function with given name is allowed to be used
as functional default for a column, {@code false} otherwise.
- */
- static boolean isSupportedFunctionalDefault(String functionName) {
- return
FUNCTIONAL_DEFAULT_FUNCTIONS.contains(functionName.toUpperCase());
- }
-
/**
* Check if provided default value is a constant or a functional default
of supported function, or fail otherwise.
*/
- static void ensureSupportedDefault(String columnName, @Nullable
DefaultValue defaultValue) {
+ static void ensureSupportedDefault(String columnName, @Nullable
DefaultValue defaultValue, ColumnType columnType) {
Review Comment:
```suggestion
static void ensureSupportedDefault(String columnName, ColumnType
columnType, @Nullable DefaultValue defaultValue) {
```
to simplify future merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
