Cyrill commented on code in PR #3784:
URL: https://github.com/apache/ignite-3/pull/3784#discussion_r1613293780
##########
modules/core/src/main/java/org/apache/ignite/internal/manager/IgniteComponent.java:
##########
@@ -28,12 +30,13 @@ public interface IgniteComponent {
* thread pools and threads goes here.
*
* <p>All actions in the component startup is divided into two categories:
sync actions,
- * that can be executed synchronously in order for the component to be
usable by other components during their startup,
- * and async actions, that are wrapped in a CompletableFuture and returned
from the start method.
+ * that can be executed synchronously in order for the component to be
usable by other components during their startup, and async
+ * actions, that are wrapped in a CompletableFuture and returned from the
start method.
*
+ * @param startupExecutor The executor that will execute the async part of
start.
* @return Future that will be completed when the asynchronous part of the
start is processed.
*/
- CompletableFuture<Void> startAsync();
+ CompletableFuture<Void> startAsync(ExecutorService startupExecutor);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
