zstan commented on code in PR #3798:
URL: https://github.com/apache/ignite-3/pull/3798#discussion_r1611644937
##########
modules/jdbc/src/integrationTest/java/org/apache/ignite/jdbc/ItJdbcStatementSelfTest.java:
##########
@@ -69,6 +69,10 @@ public void beforeEach() throws Exception {
@AfterEach
public void afterEach() throws Exception {
+ if (stmt != null) {
Review Comment:
already implemented in AbstractJdbcSelfTest
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -246,7 +245,8 @@ public SqlQueryProcessor(
PlacementDriver placementDriver,
SqlDistributedConfiguration clusterCfg,
SqlLocalConfiguration nodeCfg,
- TransactionInflights transactionInflights
+ TransactionInflights transactionInflights,
Review Comment:
remove it plz
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlOperationContext.java:
##########
@@ -124,21 +137,17 @@ public HybridTimestamp operationTime() {
*/
@SuppressWarnings("PublicInnerClass")
public static class Builder {
- private QueryCancel cancel = new QueryCancel();
-
private UUID queryId;
-
- private Object[] parameters = ArrayUtils.OBJECT_EMPTY_ARRAY;
-
private ZoneId timeZoneId;
-
- private @Nullable PrefetchCallback prefetchCallback;
-
+ private Object[] parameters = ArrayUtils.OBJECT_EMPTY_ARRAY;
private HybridTimestamp operationTime;
+ private QueryTransactionContext txContext;
- private String defaultSchemaName;
+ private @Nullable QueryCancel cancel;
+ private @Nullable String defaultSchemaName;
+ private @Nullable PrefetchCallback prefetchCallback;
- public Builder cancel(QueryCancel cancel) {
+ public Builder cancel(@Nullable QueryCancel cancel) {
Review Comment:
why you append @Nullable here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
