maksaska commented on code in PR #11357:
URL: https://github.com/apache/ignite/pull/11357#discussion_r1617507233
##########
modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java:
##########
@@ -259,6 +264,215 @@ public void testCacheGroupsView() throws Exception {
}
}
+ /** Tests work of {@link SystemView} for cache expiry policy info with
in-memory configuration */
+ @Test
+ public void testCacheViewExpiryPolicyWithInMemory() throws Exception {
+ testCacheViewExpiryPolicy(false);
+ }
+
+ /** Tests work of {@link SystemView} for cache expiry policy info with
persist configuration*/
+ @Test
+ public void testCacheViewExpiryPolicyWithPersist() throws Exception {
+ testCacheViewExpiryPolicy(true);
+ }
+
+ /** Tests work of {@link SystemView} for cache groups expiry policy info */
+ private void testCacheViewExpiryPolicy(boolean withPersistance) throws
Exception {
+ try (IgniteEx g = !withPersistance ? startGrid() :
startGrid(getConfiguration().setDataStorageConfiguration(
+ new DataStorageConfiguration().setDefaultDataRegionConfiguration(
+ new DataRegionConfiguration().setPersistenceEnabled(true)
Review Comment:
I don't think so. There is a ternanry conditional operator inside the try
`IgniteEx g = !withPersistance ? startGrid() :
startGrid(getConfiguration()...`
Nevertheless, I checked the configuration for each case (`withPersistance =
true/false`), the falg is working correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
