denis-chudov commented on code in PR #3799:
URL: https://github.com/apache/ignite-3/pull/3799#discussion_r1618785993
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/PersistentTxStateVacuumizer.java:
##########
@@ -95,15 +100,29 @@ public CompletableFuture<Set<UUID>>
vacuumPersistentTxStates(Map<TablePartitionI
// timestamp) would be updated there, and then this
operation would be called from there.
// Also, we are going to send the vacuum request only
to the local node.
if (replicaMeta != null &&
localNode.id().equals(replicaMeta.getLeaseholderId())) {
+ // Filter txns to define those which persistent
states can be vacuumized.
+ Set<UUID> filteredTxIds = new HashSet<>();
+
+ for (VacuumizableTx v : txs) {
+ if (v.cleanupCompletionTimestamp == null) {
Review Comment:
This condition and all the checks are located in
`VolatileTxStateMetaStorage#vacuum` (see
`persistentVacuumOp.apply(txIds).thenAccept` )
It removes all tx states successfully processed by persistent vacuumizer,
taking the cleanup completion timestamp into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
