xtern commented on code in PR #3819:
URL: https://github.com/apache/ignite-3/pull/3819#discussion_r1618961825
##########
modules/table/src/main/java/org/apache/ignite/internal/schema/marshaller/TupleMarshallerImpl.java:
##########
@@ -187,15 +188,18 @@ private void gatherStatistics(
}
col.validate(val);
- targetTuple.values.put(col.name(), val);
if (val != null) {
+ val = MarshallerUtil.shrinkValue(val, col.type());
Review Comment:
Done, thanks
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/MarshallerUtil.java:
##########
@@ -69,6 +70,23 @@ public static int getValueSize(Object val, NativeType type)
throws InvalidTypeEx
}
}
+ /**
+ * Converts the passed value to a more compact form, if possible.
+ *
+ * @param value Field value.
+ * @param type Mapped type.
+ * @return Value in a more compact form, or the original value if it
cannot be compacted.
+ */
+ public static Object shrinkValue(Object value, NativeType type) {
Review Comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
