Cyrill commented on code in PR #3511:
URL: https://github.com/apache/ignite-3/pull/3511#discussion_r1627481880
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/tx/QueryTransactionWrapperImpl.java:
##########
@@ -42,6 +56,10 @@ public InternalTransaction unwrap() {
@Override
public CompletableFuture<Void> commitImplicit() {
+ if (transaction.isReadOnly() && committedImplicit.compareAndSet(false,
true)) {
Review Comment:
do we really need this CaS? Wouldn't it work correctly without
committedImplicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
