xtern commented on code in PR #3919:
URL: https://github.com/apache/ignite-3/pull/3919#discussion_r1638506479
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##########
Review Comment:
Maybe it’s worth adding such a comment into the `testNullDefault` also
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java:
##########
@@ -236,6 +237,7 @@ public void literalAsColumDefault() {
@Test
@SuppressWarnings("ThrowableNotThrown")
public void doNotAllowFunctionsInNonPkColumns() {
+ // // SQL Standard 2016 feature E141-07 - Basic integrity constraints.
Column defaults
Review Comment:
```suggestion
// SQL Standard 2016 feature E141-07 - Basic integrity constraints.
Column defaults
```
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItCreateTableDdlTest.java:
##########
@@ -219,6 +219,7 @@ public void explicitColocationColumnsCaseSensitive() {
@Test
public void literalAsColumDefault() {
+ // // SQL Standard 2016 feature E141-07 - Basic integrity constraints.
Column defaults
Review Comment:
```suggestion
// SQL Standard 2016 feature E141-07 - Basic integrity constraints.
Column defaults
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
