valepakh commented on code in PR #3923:
URL: https://github.com/apache/ignite-3/pull/3923#discussion_r1639793545
##########
modules/client/src/test/java/org/apache/ignite/client/fakes/FakeCompute.java:
##########
@@ -211,7 +212,7 @@ private <R> JobExecution<R>
jobExecution(CompletableFuture<R> result) {
result.whenComplete((r, throwable) -> {
JobState state = throwable != null ? FAILED : COMPLETED;
- JobStatus newStatus =
status.toBuilder().id(jobId).state(state).finishTime(Instant.now()).build();
+ JobStatus newStatus = new
JobStatusImpl.Builder(status).id(jobId).state(state).finishTime(Instant.now()).build();
Review Comment:
Maybe introduce `JobStatusImpl.builder(JobStatus status)` method and use it
instead of constructing the builder directly?
Also it seems setting `jobId` is redundant here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
