lowka commented on code in PR #4034:
URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1669630872
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java:
##########
@@ -103,6 +135,17 @@ private boolean doBinaryComparisonCoercion(SqlCallBinding
binding) {
RelDataType leftType = binding.getOperandType(0);
RelDataType rightType = binding.getOperandType(1);
+ if (SqlTypeUtil.isIntType(leftType) &&
SqlTypeUtil.isCharacter(rightType)
+ || SqlTypeUtil.isIntType(rightType) &&
SqlTypeUtil.isCharacter(leftType)) {
+
+ SqlLiteral lit = extractLiteral(call, validator);
+
+ if (lit != null) {
+ String strVal = lit.toValue();
+ checkStringContainDigitsOnly(strVal,
binding.getCall().getParserPosition());
+ }
+ }
+
//
Review Comment:
This PR updates `binaryComparisonCoercion` but `binaryArithmeticCoercion`
remains unchanged why is that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
