rpuch commented on code in PR #4061: URL: https://github.com/apache/ignite-3/pull/4061#discussion_r1670512486
########## modules/table/src/integrationTest/java/org/apache/ignite/internal/threading/ItPartitionManagerApiThreadingTest.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.threading; + +import static java.lang.Thread.currentThread; +import static org.apache.ignite.internal.PublicApiThreadingTests.anIgniteThread; +import static org.apache.ignite.internal.PublicApiThreadingTests.asyncContinuationPool; +import static org.apache.ignite.internal.TestWrappers.unwrapTableManager; +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willBe; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.either; +import static org.hamcrest.Matchers.is; + +import java.util.concurrent.CompletableFuture; +import java.util.function.Function; +import org.apache.ignite.internal.ClusterPerClassIntegrationTest; +import org.apache.ignite.internal.table.distributed.TableManager; +import org.apache.ignite.internal.table.partition.HashPartition; +import org.apache.ignite.table.Table; +import org.apache.ignite.table.Tuple; +import org.apache.ignite.table.mapper.Mapper; +import org.apache.ignite.table.partition.PartitionManager; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; + +class ItPartitionManagerApiThreadingTest extends ClusterPerClassIntegrationTest { + private static final String TABLE_NAME = "test"; + + private static final int KEY = 1; + + private static final Tuple KEY_TUPLE = Tuple.create().set("id", 1); + + @Override + protected int initialNodes() { + return 1; + } + + @BeforeEach + void createTable() { + sql("CREATE TABLE " + TABLE_NAME + " (id INT PRIMARY KEY, val VARCHAR)"); Review Comment: 'Table per test' allows to catch test failures; otherwise they were failing really rarely even without the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
