xtern commented on PR #4141: URL: https://github.com/apache/ignite-3/pull/4141#issuecomment-2258501901
Looks good, but two things with the remaining TODOs in the code worry me. I would suggest doing the following: 1. ItDynamicParameterTest Change comment ``` // https://issues.apache.org/jira/browse/IGNITE-18414 ``` to ``` // https://issues.apache.org/jira/browse/IGNITE-15200 ``` 2. In class PlatformTestNodeRunner change comment ``` // TODO IGNITE-18431 remove extra table, use TABLE_NAME_ALL_COLUMNS for SQL tests. ``` To ``` // TODO IGNITE-22856 use TABLE_NAME_ALL_COLUMNS for SQL tests, remove this table if it is no longer used // TODO IGNITE-22857 use TABLE_NAME_ALL_COLUMNS for SQL tests, remove this table if it is no longer used ``` (one for .NET and one for ODBC) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
