sanpwc commented on code in PR #4162:
URL: https://github.com/apache/ignite-3/pull/4162#discussion_r1698310054
##########
modules/network-api/src/main/java/org/apache/ignite/internal/network/TrackableNetworkMessageHandler.java:
##########
@@ -77,10 +75,9 @@ private static void maybeLogLongProcessing(NetworkMessage
message, long startTim
if (durationMillis > MESSAGING_PROCESSING_LOG_THRESHOLD_MILLIS) {
LOG.warn(
- "Message handling has been too long [duration={}ms,
message=[{}]]",
+ "Message handling has been too long [duration={}ms,
message={}]",
durationMillis,
- // Message may include sensitive data, however it seems
useful to print full message content while testing.
- includeSensitive() ? message : message.getClass()
+ LOG.isDebugEnabled() ? message :
message.toStringForLightLogging()
Review Comment:
Yep, I believe that we should retain includeSensitive. Otherwise we will log
full message that may contain sensitive data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
