sanpwc commented on code in PR #4090:
URL: https://github.com/apache/ignite-3/pull/4090#discussion_r1705442763
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -295,7 +295,7 @@ public ReplicaManager(
Executor requestsExecutor,
LongSupplier idleSafeTimePropagationPeriodMsSupplier,
FailureProcessor failureProcessor,
- Marshaller raftCommandsMarshaller,
+ @Nullable Marshaller raftCommandsMarshaller,
Review Comment:
Annotating both raftCommandsMarshaller and snapshotStorageFactory with
@Nullable is not consistent.
First of all
1. In RaftGroupOptions only commandsMarshaller is marked as @Nullable, but
snapshotStorageFactory doesn't.
2. Aforementioned fields in ReplicaManager itself aren't annotated.
3. What's the point in !null wrapped assignment like
```
if (snapshotFactory != null) {
raftGroupOptions.snapshotStorageFactory(snapshotFactory);
}
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
