ygerzhedovich commented on code in PR #4199:
URL: https://github.com/apache/ignite-3/pull/4199#discussion_r1713661042


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientMarshallingTest.java:
##########
@@ -233,13 +235,19 @@ public void testIncompatiblePojoFieldType2() {
 
     @Test
     public void testIncompatibleTupleElementType() {
-        Table table = ignite().tables().table(TABLE_NAME);
+        var tableName = "testIncompatibleTupleElementType";
+        ignite().sql().execute(null, "CREATE TABLE " + tableName + " (KEY INT 
PRIMARY KEY, VAL VARCHAR NOT NULL)");
+
+        Table table = ignite().tables().table(tableName);
         var tupleView = table.recordView();
 
-        Tuple rec = Tuple.create().set("KEY", "1").set("VAL", BigDecimal.ONE);
+        Tuple rec = Tuple.create().set("KEY", 1).set("VAL", 1L);
 
+        // The validation done on a client side (for a thin client), and 
messages may differ between embedded clients and thin clients.
+        // For an embedded client the message include type precision, but for 
a thin client it doesn't.

Review Comment:
   It sounds not so good. Should we fix messages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to