kgusakov commented on code in PR #4223:
URL: https://github.com/apache/ignite-3/pull/4223#discussion_r1718252882
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java:
##########
@@ -73,4 +74,11 @@ public interface Replica {
* Shutdowns the replica.
*/
CompletableFuture<Void> shutdown();
+
+ /**
+ * Updates peers and learners lists in raft client.
+ *
+ * @param configuration Peers and learners configuration.
+ */
+ void updateConfiguration(PeersAndLearners configuration);
Review Comment:
Could you rename it to something like
"updateReplicationClientConfiguration"? Because in the scope of Replica the
meaning of "configuration" is not obvious.
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java:
##########
@@ -73,4 +74,11 @@ public interface Replica {
* Shutdowns the replica.
*/
CompletableFuture<Void> shutdown();
+
+ /**
+ * Updates peers and learners lists in raft client.
Review Comment:
Let's use the generic "replication client" instead of "raft", because we
want to be more abstract about replication protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
