sashapolo commented on code in PR #4200:
URL: https://github.com/apache/ignite-3/pull/4200#discussion_r1723313574
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/PartitionDataHelper.java:
##########
@@ -44,45 +43,46 @@
import org.jetbrains.annotations.Nullable;
import org.rocksdb.ColumnFamilyHandle;
import org.rocksdb.ReadOptions;
+import org.rocksdb.RocksDB;
+import org.rocksdb.RocksDBException;
import org.rocksdb.RocksIterator;
import org.rocksdb.Slice;
import org.rocksdb.WriteBatchWithIndex;
/** Helper for the partition data. */
public final class PartitionDataHelper implements ManuallyCloseable {
+ /** Transaction id size (part of the transaction state). */
+ private static final int TX_ID_SIZE = 2 * Long.BYTES;
+
/** Position of row id inside the key. */
- static final int ROW_ID_OFFSET = TABLE_ID_SIZE + Short.BYTES;
+ static final int ROW_ID_OFFSET = TABLE_ID_SIZE + PARTITION_ID_SIZE;
- /** Size of the key without timestamp. */
Review Comment:
Intentional, but I forgot to add a new javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
