valepakh commented on code in PR #4244:
URL: https://github.com/apache/ignite-3/pull/4244#discussion_r1724766591
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/configuration/ClientHandlerConfigurationModule.java:
##########
@@ -35,7 +34,7 @@ public ConfigurationType type() {
}
@Override
- public Collection<RootKey<?, ?>> rootKeys() {
- return Collections.singleton(ClientConnectorConfiguration.KEY);
+ public Collection<Class<?>> schemaExtensions() {
+ return List.of(ClientConnectorExtensionConfigurationSchema.class);
Review Comment:
> It just looks like there must be a shortcut to avoid manually creating an
empty class, but I might be wrong.
Initially I though that we could generate this but since this is also an
annotated class, it's impossible.
Probably we could generate this class as non-annotated and generate
Configuration, Change and View interfaces as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]