ptupitsyn commented on code in PR #4142: URL: https://github.com/apache/ignite-3/pull/4142#discussion_r1726847937
########## modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientComputeJobUnpacker.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.client.proto; + +import static org.apache.ignite.marshalling.Marshaller.tryUnmarshalOrCast; + +import org.apache.ignite.internal.binarytuple.inlineschema.TupleWithSchemaMarshalling; +import org.apache.ignite.marshalling.Marshaller; +import org.apache.ignite.marshalling.UnmarshallingException; +import org.jetbrains.annotations.Nullable; + +/** Unpacks job arguments and results. */ +public final class ClientComputeJobUnpacker { + /** + * Unpacks compute job argument. If the marshaller is provided, it will be used to unmarshal the argument. If the marshaller is not + * provided and the argument is a native column type or a tuple, it will be unpacked accordingly. + * + * @param marshaller Marshaller. + * @param unpacker Unpacker. + * @return Unpacked argument. + */ + public static @Nullable Object unpackJobArgument(@Nullable Marshaller<?, byte[]> marshaller, ClientMessageUnpacker unpacker) { + return unpack(marshaller, unpacker); + } + + /** + * Unpacks compute job result. If the marshaller is provided, it will be used to unmarshal the result. If the marshaller is not provided + * and the result is a native column type or a tuple, it will be unpacked accordingly. + * + * @param marshaller Marshaller. + * @param unpacker Unpacker. + * @return Unpacked result. + */ + public static @Nullable Object unpackJobResult(@Nullable Marshaller<?, byte[]> marshaller, ClientMessageUnpacker unpacker) { + return unpack(marshaller, unpacker); + } + + /** Underlying byte array expected to be in the following format: | typeId | value |. */ + private static @Nullable Object unpack(@Nullable Marshaller<?, byte[]> marshaller, ClientMessageUnpacker unpacker) { + if (unpacker.tryUnpackNil()) { + return null; + } + + int typeId = unpacker.unpackInt(); + var type = ComputeJobType.Type.fromId(typeId); + + switch (type) { + case NATIVE: + if (marshaller != null) { + throw new UnmarshallingException( + "Can not unpack object because the marshaller is provided but the object were packed without marshaller." + ); + } + + return unpacker.unpackObjectFromBinaryTuple(); + case MARSHALLED_TUPLE: + return TupleWithSchemaMarshalling.unmarshal(unpacker.readBinary()); + + case MARSHALLED_OBJECT: + if (marshaller == null) { + throw new UnmarshallingException( + "Can not unpack object because the marshaller is not provided but the object were packed with marshaller." Review Comment: ```suggestion "Can not unpack object because the marshaller is not provided but the object was packed with marshaller." ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
