Vladsz83 commented on code in PR #11478:
URL: https://github.com/apache/ignite/pull/11478#discussion_r1732882649
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/RexImpTable.java:
##########
@@ -391,31 +402,30 @@ public class RexImpTable {
map.put(IS_NOT_FALSE, new IsNotFalseImplementor());
// LIKE and SIMILAR
- final MethodImplementor likeImplementor =
- new MethodImplementor(BuiltInMethod.LIKE.method, NullPolicy.STRICT,
- false);
- map.put(LIKE, likeImplementor);
- map.put(NOT_LIKE, likeImplementor);
- final MethodImplementor similarImplementor =
- new MethodImplementor(BuiltInMethod.SIMILAR.method,
NullPolicy.STRICT,
- false);
- map.put(SIMILAR_TO, similarImplementor);
- map.put(NOT_SIMILAR_TO, NotImplementor.of(similarImplementor));
+ defineReflective(LIKE, BuiltInMethod.LIKE.method,
+ BuiltInMethod.LIKE_ESCAPE.method);
+ defineReflective(ILIKE, BuiltInMethod.ILIKE.method,
+ BuiltInMethod.ILIKE_ESCAPE.method);
+ defineReflective(RLIKE, BuiltInMethod.RLIKE.method);
+ defineReflective(SIMILAR_TO, BuiltInMethod.SIMILAR.method,
+ BuiltInMethod.SIMILAR_ESCAPE.method);
// POSIX REGEX
- final MethodImplementor posixRegexImplementorCaseSensitive =
- new PosixRegexMethodImplementor(true);
- final MethodImplementor posixRegexImplementorCaseInsensitive =
- new PosixRegexMethodImplementor(false);
- map.put(SqlStdOperatorTable.POSIX_REGEX_CASE_INSENSITIVE,
- posixRegexImplementorCaseInsensitive);
- map.put(SqlStdOperatorTable.POSIX_REGEX_CASE_SENSITIVE,
- posixRegexImplementorCaseSensitive);
- map.put(SqlStdOperatorTable.NEGATED_POSIX_REGEX_CASE_INSENSITIVE,
- NotImplementor.of(posixRegexImplementorCaseInsensitive));
- map.put(SqlStdOperatorTable.NEGATED_POSIX_REGEX_CASE_SENSITIVE,
- NotImplementor.of(posixRegexImplementorCaseSensitive));
- map.put(REGEXP_REPLACE, new RegexpReplaceImplementor());
+ ReflectiveImplementor insensitiveImplementor =
Review Comment:
Do we need `TRY_CAST`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
