xtern commented on code in PR #4256:
URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1734730578
##########
modules/catalog-compaction/src/integrationTest/java/org/apache/ignite/internal/catalog/compaction/ItCatalogCompactionTest.java:
##########
@@ -67,11 +77,71 @@
class ItCatalogCompactionTest extends ClusterPerClassIntegrationTest {
private static final int CLUSTER_SIZE = 3;
+ /** How often we update the low water mark. */
+ private static final long LW_UPDATE_TIME_MS =
TimeUnit.SECONDS.toMillis(10);
Review Comment:
@lowka
The idea of the test is to check that 'minActiveTxBeginTime` on all
partition listeners updated, not **snapshotted** minActiveTxTime.
And the original `minActiveTxBeginTime` (not
`snapshottedMinActiveTxBeginTime`) was required ONLY for this test.
Since you removed this field (renamed `snapshottedMinActiveTxBeginTime` to
`minActiveTxBeginTime` ) and since now we have full integration test for
catalog compaction runner, I suggest to remove `testRaftGroupsUpdate` because
it will not work properly until fully reworked, and, again we already have full
it-test for this .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
