ibessonov commented on code in PR #4372:
URL: https://github.com/apache/ignite-3/pull/4372#discussion_r1754705225
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -280,9 +287,19 @@ void doCompaction() {
// Wait and check for errors.
CompletableFuture.allOf(futures).join();
Review Comment:
Yes, here it's OK, it can only stuck in case of disk failure, and even then
we will get an error eventually. I would change the way we handle component
shutdown here, but definitely not in this ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
