xtern commented on PR #4370:
URL: https://github.com/apache/ignite-3/pull/4370#issuecomment-2348294061
> Look, it`s very strange approach to modify a tree on validation. I remove
all usage of "syncSelectList" from code and only planner tests with some
projection expectations are failed. As for me - if this approach is correct
seems we need some kind of integrations test but i found no one, wdyt ? with
removed "syncSelectList" your tests are passed too.
Yes, may be we don't have enough integration tests, but this method is
needed to "copy" necessary casts, example
```
sql("create table t0 (id int primary key, val int)");
sql("insert into t0 values (0, 0)");
// without this method next statement fails with "class
java.lang.Long cannot be cast to class java.lang.Integer"
sql("update t0 set val = ? where id = ?", 1L, 0L);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
