isapego commented on code in PR #4401:
URL: https://github.com/apache/ignite-3/pull/4401#discussion_r1762579638
##########
modules/platforms/python/cpp_module/type_conversion.h:
##########
@@ -185,6 +377,10 @@ static void submit_pyobject(ignite::binary_tuple_builder
&builder, PyObject *obj
if (PyLong_Check(obj)) {
auto val = PyLong_AsLongLong(obj);
+ if (PyErr_Occurred()) {
+ throw ignite::ignite_error("Can not convert INT to a long long");
Review Comment:
This is actually possible, when a really big int is used in Python (e.g., I
tried
`423538409739423538409739423538409739423538409739423538409739423538409739423538409739`
and got this error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
