nizhikov commented on code in PR #11537:
URL: https://github.com/apache/ignite/pull/11537#discussion_r1762649049
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTxLocal.java:
##########
@@ -2306,19 +2306,21 @@ private <K, V> Collection<KeyCacheObject> enlistRead(
if (!F.isEmpty(txEntry.entryProcessors()))
val =
txEntry.applyEntryProcessors(val);
- cacheCtx.addResult(map,
- key,
- val,
- skipVals,
- keepCacheObjects,
- deserializeBinary,
- false,
- getRes,
- readVer,
- 0,
- 0,
- needVer,
-
U.deploymentClassLoader(cctx.kernalContext(), deploymentLdrId));
+ if (val != null) {
+ cacheCtx.addResult(map,
+ key,
+ val,
+ skipVals,
+ keepCacheObjects,
+ deserializeBinary,
+ false,
+ getRes,
+ readVer,
+ 0,
+ 0,
+ needVer,
+
U.deploymentClassLoader(cctx.kernalContext(), deploymentLdrId));
+ }
Review Comment:
missedKeys means "not found in cache" - so here we in the branch where key
was found in cache but removed by entryProcessor.
Looks like no, we don't have to add in missedKey set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
