valepakh commented on code in PR #4438:
URL: https://github.com/apache/ignite-3/pull/4438#discussion_r1774673688
##########
modules/api/src/main/java/org/apache/ignite/compute/JobDescriptor.java:
##########
@@ -100,12 +104,16 @@ public static <T, R> Builder<T, R> builder(Class<?
extends ComputeJob<T, R>> job
return new Builder<>(jobClass.getName());
}
+ public @Nullable Marshaller<T, byte[]> argumentMarshaller() {
+ return argumentMarshaller;
+ }
+
public @Nullable Marshaller<R, byte[]> resultMarshaller() {
return resultMarshaller;
}
- public @Nullable Marshaller<T, byte[]> argumentMarshaller() {
- return argumentMarshaller;
+ public @Nullable Class<?> resultClass() {
Review Comment:
> So we can infer job argument type from the overridden method, but we can't
do it for the result because of type erasure, and we have to ask the user to
provide the class explicitly - is my understanding correct?
Yes, exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]