rpuch commented on code in PR #4528:
URL: https://github.com/apache/ignite-3/pull/4528#discussion_r1793546147
##########
modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/RocksDbCompactionKeyValueStorageTest.java:
##########
@@ -17,13 +17,29 @@
package org.apache.ignite.internal.metastorage.server;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
import org.apache.ignite.internal.failure.NoOpFailureManager;
import
org.apache.ignite.internal.metastorage.server.persistence.RocksDbKeyValueStorage;
+import org.junit.jupiter.api.Test;
/** Compaction test for the RocksDB implementation of {@link KeyValueStorage}.
*/
public class RocksDbCompactionKeyValueStorageTest extends
AbstractCompactionKeyValueStorageTest {
@Override
public KeyValueStorage createStorage() {
return new RocksDbKeyValueStorage("test", workDir.resolve("storage"),
new NoOpFailureManager());
}
+
+ @Test
+ void checksumsAreRemovedForCompactedRevisions() {
Review Comment:
As we only support checksums in the RocksDB-based storage (and it makes no
sense to support checksums in the in-mem storage), it is natural to only have
these tests here, not in the base class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
