korlov42 commented on code in PR #4478:
URL: https://github.com/apache/ignite-3/pull/4478#discussion_r1794759819
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexImpTable.java:
##########
@@ -3077,6 +3077,16 @@ private static class BinaryImplementor extends
AbstractRexCallImplementor {
argValueList = FlatLists.append(argValueList, fieldComparator);
}
+ if (type0 == BigDecimal.class && type1 == BigDecimal.class && op ==
DIVIDE) {
Review Comment:
I see where I was wrong: we use `MethodImplementor` for `DECIMAL_DEVIDE`,
but changes in question in `BinaryImplementor` and `harmonize` flag is indeed
set to `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
