xtern commented on code in PR #4566:
URL: https://github.com/apache/ignite-3/pull/4566#discussion_r1803038245
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDynamicParameterTest.java:
##########
@@ -81,9 +82,12 @@ void testMetadataTypesForDynamicParameters(ColumnType type) {
// TODO https://issues.apache.org/jira/browse/IGNITE-19162 Ignite SQL
doesn't support precision more than 3 for temporal types.
if (type == ColumnType.TIME || type == ColumnType.TIMESTAMP || type ==
ColumnType.DATETIME) {
param = SqlTestUtils.generateValueByType(type, 3, -1);
+ } else if (type == ColumnType.DECIMAL) { // by default derived type of
parameter of type BigDecimal is DECIMAL(28, 6)
+ param = SqlTestUtils.generateValueByType(type, 28, 6);
Review Comment:
why not use constants?
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/NumericCaseTypeCoercionTest.java:
##########
@@ -51,7 +50,7 @@
public class NumericCaseTypeCoercionTest extends BaseTypeCoercionTest {
private static final IgniteSchema SCHEMA =
createSchemaWithTwoColumnTable(NativeTypes.STRING, NativeTypes.STRING);
- private static final NativeType DECIMAL_MAX_PREC =
NativeTypes.decimalOf(MAX_DECIMAL_PRECISION, 0);
+ private static final NativeType DECIMAL_DYN_PARAM_DEFAULT =
NativeTypes.decimalOf(28, 6);
Review Comment:
why not use `DECIMAL_DYNAMIC_PARAM_PRECISION` and
`DECIMAL_DYNAMIC_PARAM_SCALE` constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
