tkalkirill commented on code in PR #4602:
URL: https://github.com/apache/ignite-3/pull/4602#discussion_r1808676328
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -423,4 +423,11 @@ public interface MetaStorageManager extends
IgniteComponent {
/** Unregisters a Meta Storage revision update listener. */
void unregisterRevisionUpdateListener(RevisionUpdateListener listener);
+
+ /**
+ * Returns the local compaction revision that was set or restored from a
metastorage snapshot, {@code -1} if not changed.
+ *
+ * @throws IgniteInternalException with cause {@link
NodeStoppingException} if the node is in the process of stopping.
Review Comment:
This is a convenient auxiliary method, which is already used in many parts
when, it can be remade for all, but not in this task of course. I think that
the main headache is that the exception extends the checked exception, which of
course we do not like very much now.
NodeStoppingException extends IgniteInternalCheckedException
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -423,4 +423,11 @@ public interface MetaStorageManager extends
IgniteComponent {
/** Unregisters a Meta Storage revision update listener. */
void unregisterRevisionUpdateListener(RevisionUpdateListener listener);
+
+ /**
+ * Returns the local compaction revision that was set or restored from a
metastorage snapshot, {@code -1} if not changed.
+ *
+ * @throws IgniteInternalException with cause {@link
NodeStoppingException} if the node is in the process of stopping.
Review Comment:
This is a convenient auxiliary method, which is already used in many parts
when, it can be remade for all, but not in this task of course. I think that
the main headache is that the exception extends the checked exception, which of
course we do not like very much now.
`NodeStoppingException extends IgniteInternalCheckedException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
