nizhikov commented on code in PR #11518: URL: https://github.com/apache/ignite/pull/11518#discussion_r1828880676
########## modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcBinaryBuffer.java: ########## @@ -0,0 +1,463 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.jdbc2; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.Objects; +import org.apache.ignite.internal.util.typedef.internal.U; + +import static org.apache.ignite.internal.binary.streams.BinaryAbstractOutputStream.MAX_ARRAY_SIZE; + +/** + * Buffer storing the binary data. + * + * <p>Buffer can start working in read-only mode if created wrapping the existing byte array which + * can not be modified. Any write operation switches it lazily to the read-write mode. This allows + * to prevent the unnecessary data copying. + * + * <p>Data may be read via the InputStream API and modified via the OutputStream one. Changes done via + * OutputStream are visible via the InputStream even if InputStream is created before changes done. + * + * <p>InputStream and OutputStream created remain valid even if the underlying data storage changed from + * read-only to read-write. + * + * <p>Note however that implementation is not thread-safe. + */ +public class JdbcBinaryBuffer { + /** Byte array storing data. */ + private byte[] arr; + + /** Offset the data starts in the array. */ + private int off; + + /** The length of data. */ + private int length; Review Comment: length -> len - let's use consistent naming across all codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
