Cyrill commented on code in PR #4667:
URL: https://github.com/apache/ignite-3/pull/4667#discussion_r1829310316
##########
modules/catalog-dsl/src/main/java/org/apache/ignite/internal/catalog/sql/CreateFromDefinitionImpl.java:
##########
@@ -84,6 +84,10 @@ CreateFromDefinitionImpl from(ZoneDefinition def) {
if (!StringUtils.nullOrBlank(def.filter())) {
createZone.filter(def.filter());
}
+
+ if (!StringUtils.nullOrBlank(def.consistencyMode())) {
Review Comment:
Well, it's validated in DdlSqlToCommandConverter.
I see there are a few places where the validation is performed. Which of
them are mandatory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
