tkalkirill commented on code in PR #4689:
URL: https://github.com/apache/ignite-3/pull/4689#discussion_r1833854205
##########
modules/network/src/main/java/org/apache/ignite/internal/network/netty/OutboundEncoder.java:
##########
@@ -98,11 +98,17 @@ private NetworkMessageChunkedInput(
this.serializationService = serializationService;
this.msg = outObject.networkMessage();
- List<ClassDescriptorMessage> outDescriptors =
outObject.descriptors().stream()
- .filter(classDescriptorMessage ->
!serializationService.isDescriptorSent(classDescriptorMessage.descriptorId()))
- .collect(Collectors.toList());
+ List<ClassDescriptorMessage> outDescriptors = null;
+ for (ClassDescriptorMessage classDescriptorMessage :
outObject.descriptors()) {
Review Comment:
From my experience, I can say that I came across a situation in projects
when we started to see a lot of iterator allocations in the product profiler in
places where this should have been optimized as well. I assume that this could
happen because JIT threw out optimizations for various reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
