ascherbakoff commented on code in PR #2537:
URL: https://github.com/apache/ignite-3/pull/2537#discussion_r1834007776
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/IgniteTransactionsImpl.java:
##########
@@ -103,8 +103,18 @@ public CompletableFuture<Transaction> beginAsync(@Nullable
TransactionOptions op
return CompletableFuture.completedFuture(begin(options));
}
+ /**
+ * Begins a transaction.
+ *
+ * @param readOnly {@code true} in order to start a read-only transaction,
{@code false} in order to start read-write one.
+ * @return The started transaction.
+ */
+ public InternalTransaction beginImplicit(boolean readOnly) {
Review Comment:
I believe it's not OK to add implicit flag to a transaction state as the
part of this PR.
This introduces a lot of unrelated bloating changes and better to be done as
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
