nizhikov commented on code in PR #11618:
URL: https://github.com/apache/ignite/pull/11618#discussion_r1849828368


##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2SchemaManager.java:
##########
@@ -221,6 +222,12 @@ private void dropTable(H2TableDescriptor tbl) {
 
     /** {@inheritDoc} */
     @Override public void onFunctionCreated(String schema, String name, 
boolean deterministic, Method method) {
+        if (!Modifier.isStatic(method.getModifiers())) {
+            log.warning("Skip creating SQL function '" + name + "' in H2 
engine because it is not static.");

Review Comment:
   Let's use `LT.warn` here to reduce number of logging in case user 
application generates a lot of query with the same UDF.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to