sanpwc commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1850877190
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -150,7 +151,7 @@ public class ReplicaManager extends
AbstractEventProducer<LocalReplicaEvent, Loc
private static final PlacementDriverMessagesFactory
PLACEMENT_DRIVER_MESSAGES_FACTORY = new PlacementDriverMessagesFactory();
/** Busy lock to stop synchronously. */
- private final IgniteSpinBusyLock busyLock = new IgniteSpinBusyLock();
+ private final IgniteStripedReadWriteLock busyLock = new
IgniteStripedReadWriteLock();
Review Comment:
Same as above, the contract is messy. ReplicaManager is not an utility
class, thus it's unlikely that stopAsync will be called in the same thread that
will also acquire readLocks. However, from the busyLock's general perspective,
it's still a violation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
